pixel based query rects for raster requests #854
+35,055
−12,412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-based-queries-rebase
…-based-queries-rebase
…-based-queries-rebase
…-based-queries-rebase
…-based-queries-rebase
…-based-queries-rebase
…eo-engine/geoengine into new_gdal_source_workflow_optimization
…-based-queries-rebase
…eo-engine/geoengine into new_gdal_source_workflow_optimization
…eo-engine/geoengine into new_gdal_source_workflow_optimization
- [ ] I added an entry to [`CHANGELOG.md`](CHANGELOG.md) if knowledge of this change could be valuable to users. --- Here is a brief summary of what I did: <TEXT>
- [ ] I added an entry to [`CHANGELOG.md`](CHANGELOG.md) if knowledge of this change could be valuable to users. --- Here is a brief summary of what I did: <TEXT>
…-based-queries-rebase
…-based-queries-rebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG.mdif knowledge of this change could be valuable to users.Here is a brief summary of what I did:
This PR changes the QueryRectangle struct to combine a temporal and a spatial query.
All QueryRectangles are now created using a static constructor method.
VectorQueryRectangle use the same components as before just different composition.
RasterQueryRectangle now use a GridBounds in Pixels.
Projection might still have a 1Px offset issue:
TODO: Tests
TODO: Re-Grid-Operator